Skip to content

Feature 336 centralize hardcoded lists#345

Merged
deniztepe merged 4 commits intodevelopfrom
feature-336-centralize-hardcoded-lists
Sep 21, 2022
Merged

Feature 336 centralize hardcoded lists#345
deniztepe merged 4 commits intodevelopfrom
feature-336-centralize-hardcoded-lists

Conversation

@deniztepe
Copy link
Copy Markdown
Contributor

The script constants.py covers variables that are fix and needed throughout the module. This reduces the code length and improves the readability.

@deniztepe deniztepe added the 🚀 feature New feature or request label Sep 13, 2022
@deniztepe deniztepe requested a review from chrwm September 13, 2022 10:26
@deniztepe deniztepe self-assigned this Sep 13, 2022
@deniztepe deniztepe marked this pull request as ready for review September 13, 2022 10:26
Copy link
Copy Markdown
Member

@chrwm chrwm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine!

@deniztepe deniztepe merged commit f69c780 into develop Sep 21, 2022
@deniztepe deniztepe deleted the feature-336-centralize-hardcoded-lists branch September 21, 2022 08:37
@deniztepe deniztepe mentioned this pull request Oct 21, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🚀 feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants