Skip to content

Fix csv export#384

Merged
chrwm merged 11 commits intodevelopfrom
bugfix-383-fix-csv-export
Nov 24, 2022
Merged

Fix csv export#384
chrwm merged 11 commits intodevelopfrom
bugfix-383-fix-csv-export

Conversation

@chrwm
Copy link
Copy Markdown
Member

@chrwm chrwm commented Nov 18, 2022 •
edited
Loading

Closes #385

  • Fix mixed csv encoding, all exported csv tables are now encoded in 'utf-8'

Fixes #383

  • Export of additional database tables works again

@chrwm chrwm self-assigned this Nov 18, 2022
@chrwm chrwm changed the base branch from production to develop November 18, 2022 18:23
chrwm added 4 commits November 21, 2022 21:23
Add case to handle BUlK default tables #383
f478203 
* add tqdm for additional table export
* rename second table variable
Add csv export mapping for bulk tables #383
64c306e
Refactor data_to_include_tables() #383
2f566f6 
* Move method to helpers.py
* Add 'source' parameter to choose mapping
* Add NotImplementedException
Add tqdm to reverse_fill_basic_units #383
08cb565
@chrwm chrwm marked this pull request as ready for review November 21, 2022 21:36
@chrwm
Copy link
Copy Markdown
Member Author

chrwm commented Nov 21, 2022

I haven't checked the test yet. They might fail.

@chrwm chrwm marked this pull request as draft November 22, 2022 15:01
Add test for non-existent 'mapping' parameter #383
0ff6a82 
* raise NotImplementedError successfully
* run black
@chrwm chrwm marked this pull request as ready for review November 22, 2022 15:44
FlorianK13
FlorianK13 reviewed Nov 24, 2022
View reviewed changes
Comment thread open_mastr/mastr.py
"""
log.info("Starting csv-export")

create_data_dir()
Copy link
Copy Markdown
Member

@FlorianK13 FlorianK13 Nov 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we delete this function here @chrwm ?

Copy link
Copy Markdown
Member Author

@chrwm chrwm Nov 24, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I think so. Wasn't it done here?

@chrwm chrwm merged commit 6010f89 into develop Nov 24, 2022
@chrwm chrwm deleted the bugfix-383-fix-csv-export branch November 24, 2022 14:49
This was referenced Nov 24, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FlorianK13 FlorianK13 FlorianK13 approved these changes

@deniztepe deniztepe Awaiting requested review from deniztepe

Assignees

@chrwm chrwm

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Some DB tables are not dumped when using db.to_csv()

2 participants

@chrwm @FlorianK13
⚡