Skip to content

Bugfix 453 readthedocs#454

Merged
FlorianK13 merged 7 commits intodevelopfrom
bugfix-453-readthedocs
Jul 19, 2023
Merged

Bugfix 453 readthedocs#454
FlorianK13 merged 7 commits intodevelopfrom
bugfix-453-readthedocs

Conversation

@FlorianK13
Copy link
Copy Markdown
Member

Summary of the discussion

Fix the bug that makes the readthedocs workflow fail.

Workflow checklist

Automation

Closes #

PR-Assignee

Reviewer

  • 🐙 Follow the Reviewer Guidelines
  • 🐙 Provided feedback and show sufficient appreciation for the work done

Also test the readthedocs workflow
Additionally move files to the folder raw
Hope this will change the behaviour of readthedocs
@FlorianK13 FlorianK13 marked this pull request as ready for review July 19, 2023 07:05
@FlorianK13
Copy link
Copy Markdown
Member Author

@chrwm Note the changes in the pre-commit hook. The hook didn't work for me and it took a while since I figured out that it is due to the python version in the config file (I'm using 3.10). I wanted to change this file only locally but it doesn't allow any new commits as long as the pre-commit config file is not commited.

So can we switch to python 3.10 when developing open-mastr?

@FlorianK13 FlorianK13 requested a review from chrwm July 19, 2023 07:07
Copy link
Copy Markdown
Member

@chrwm chrwm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@FlorianK13 FlorianK13 merged commit 6966e1a into develop Jul 19, 2023
@FlorianK13 FlorianK13 deleted the bugfix-453-readthedocs branch July 19, 2023 14:21
@FlorianK13 FlorianK13 restored the bugfix-453-readthedocs branch August 16, 2023 07:45
@FlorianK13 FlorianK13 deleted the bugfix-453-readthedocs branch August 16, 2023 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants