Create Mastr.translate method #461#471
Merged
FlorianK13 merged 16 commits intoOpenEnergyPlatform:developfrom Nov 3, 2023
Merged
Create Mastr.translate method #461#471FlorianK13 merged 16 commits intoOpenEnergyPlatform:developfrom
FlorianK13 merged 16 commits intoOpenEnergyPlatform:developfrom
Conversation
added 7 commits
September 19, 2023 14:35
FlorianK13
requested changes
Oct 18, 2023
Member
FlorianK13
left a comment
There was a problem hiding this comment.
Thanks for your PR @Grazvy I have added a few comments, we can also discuss them further.
1 task
FlorianK13
approved these changes
Nov 2, 2023
Member
|
Github secrets are not communicated to external PRs, hence the API tests cannot run successfully. I propose we merge it anyway and see if the tests run when we want to merge to production? |
Member
|
The tests for this branch are also failing locally, I will investigate why this is the case before we merge. |
Member
|
Tests suceeded locally, hence I will merge it now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the discussion
Describe the findings of the discussion in the issue or meeting.
Type of change (CHANGELOG.md)
Added
Updated
Removed
Workflow checklist
Automation
Closes #
PR-Assignee
Reviewer