Skip to content

Improvements in handling bulk downloads#667

Merged
nesnoj merged 14 commits intodevelopfrom
feature-564-keep-old-bulk-files
Nov 11, 2025
Merged

Improvements in handling bulk downloads#667
nesnoj merged 14 commits intodevelopfrom
feature-564-keep-old-bulk-files

Conversation

@nesnoj
Copy link
Copy Markdown
Collaborator

@nesnoj nesnoj commented Oct 21, 2025 •
edited
Loading

Summary of the discussion

  • Introduce parameter to allow keeping old XML files Prior bulk zip files are deleted on download #564
  • Prevent deletion of up-to-date zip file on full bulk download Zip file is deleted on full bulk download #668
  • Add technology checks to full bulk download -> do not download if data is present; fixed behavior for full and partial download:
    • zip file does contain all technologies -> use existing zip file
    • zip file does not contain all requested technologies -> download full / partial

Workflow checklist

Automation

Closes #564
Fixes #668

PR-Assignee

Reviewer

  • 🐙 Follow the Reviewer Guidelines
  • 🐙 Provided feedback and show sufficient appreciation for the work done

@nesnoj nesnoj self-assigned this Oct 21, 2025
@nesnoj nesnoj mentioned this pull request Oct 21, 2025
Closed
@nesnoj nesnoj changed the title Keep old bulk files and fix bulk file deletion Keep old bulk files, fix bulk file deletion, extend bulk file checks Oct 21, 2025
@nesnoj nesnoj changed the title Keep old bulk files, fix bulk file deletion, extend bulk file checks Improvements in handling bulk downloads Oct 21, 2025
@nesnoj nesnoj marked this pull request as ready for review October 21, 2025 13:36
@nesnoj nesnoj added 🐛 bug Something isn't working 🚀 feature New feature or request labels Oct 21, 2025
@nesnoj nesnoj requested a review from FlorianK13 October 21, 2025 14:49
FlorianK13
FlorianK13 reviewed Oct 24, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@FlorianK13 FlorianK13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a first comment here, but I haven't finished the review yet (was running out of time)

Comment thread open_mastr/xml_download/utils_download_bulk.py
FlorianK13
FlorianK13 approved these changes Nov 11, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@FlorianK13 FlorianK13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@nesnoj nesnoj merged commit e8fb628 into develop Nov 11, 2025
9 checks passed
@nesnoj nesnoj deleted the feature-564-keep-old-bulk-files branch November 11, 2025 08:58
@nesnoj nesnoj mentioned this pull request Nov 25, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FlorianK13 FlorianK13 FlorianK13 approved these changes

Assignees

@nesnoj nesnoj

Labels

🐛 bug Something isn't working 🚀 feature New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Zip file is deleted on full bulk download Prior bulk zip files are deleted on download

2 participants

@nesnoj @FlorianK13
⚡