Feature/v0.17.0 - AWSF Dev Days #59
Merged
reinecke merged 5 commits intoOpenTimelineIO:mainfrom Sep 25, 2024
Merged
Conversation
vade
force-pushed
the
feature/v0.17.0
branch
from
57d7875 to
91fadb1
Compare
Signed-off-by: vade <vade@vade.info>
Signed-off-by: vade <vade@vade.info>
Signed-off-by: vade <vade@vade.info>
Signed-off-by: vade <vade@vade.info>
Signed-off-by: vade <vade@vade.info>
vade
force-pushed
the
feature/v0.17.0
branch
from
bc8760a to
3e4d4b7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link the Issue(s) this Pull Request is related to.
Fixes #58Summarize your change.
This PR updates the Swift Bindings package to support OTIO v0.17.0
For Reviewers: Please note that this change introduces some minor changes to support OTIO's migration from
otio::anytostd::anyas per similar changes in OpenTimelineIO/raven#46To support
std::anywe also needed to update the Swift Package version to 5.5 (perhaps 5.4 is the minimal?) and update the cxx version, as well as change some search paths in the Package Definition.We also had some changes to the Obj-C / C++ bridging code which references
otio:any, as well asotio::optionalandotio::nulloptto their std counterparts.We also remove the
anyandoptional litepackage libraries, shim code, and references since we no longer need themWe presume things are working as
swift testpasses completely. We include no new tests as we aren't changing functionality on the exposed swift or otio api surface area.Thank you!