fix(TXDAT, RXDAT, MMIOBridge): DataCheck uses odd parity, and support NC#329
Merged
fix(TXDAT, RXDAT, MMIOBridge): DataCheck uses odd parity, and support NC#329
Conversation
Ma-YX
requested review from
Ivyfeather,
Kumonda221-CrO3 and
linjuanZ
as code owners
Ma-YX
changed the title
linjuanZ
approved these changes
Jan 15, 2025
cyril0124
pushed a commit
to cyril0124/CoupledL2
that referenced
this pull request
Jan 21, 2025
… NC (OpenXiangShan#329) This pr fixes bugs concerning `DataCheck`: * According to the CHI manual, `DataCheck` should use odd parity. Fixed the issue where even parity was incorrectly used in `TXDAT` and `RXDAT`: the parity bit should be obtained by XOR all bits of the data and then XOR the result with 1. * Should use `VecInit` instead of `Cat` to avoid reverse sequence. * In `MMIOBridge`, `DataCheck` operations, which are the same as those in `TXDAT` & `RXDAT`, are added for `NC`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr fixes bugs concerning
DataCheck:DataCheckshould use odd parity. Fixed the issue where even parity was incorrectly used inTXDATandRXDAT: the parity bit should be obtained by XOR all bits of the data and then XOR the result with 1.VecInitinstead ofCatto avoid reverse sequence.MMIOBridge,DataCheckoperations, which are the same as those inTXDAT&RXDAT, are added forNC.