fix(AsyncBridge): handle lcredit return sequence safely#478
Open
yulightenyu wants to merge 17 commits intomasterfrom
Open
fix(AsyncBridge): handle lcredit return sequence safely#478yulightenyu wants to merge 17 commits intomasterfrom
yulightenyu wants to merge 17 commits intomasterfrom
Conversation
Contributor
yulightenyu
commented
Mar 7, 2026
yulightenyu
commented
yulightenyu
requested review from
Ivyfeather,
Kumonda221-CrO3 and
linjuanZ
as code owners
yulightenyu
changed the title
yulightenyu
force-pushed
the
return_lcredit_issue
branch
from
1cdb01b to
b6cdd72
Compare
* Add power handshake to confirm sink Tx Queues are drained before power-down * Change return l-credit in DEACTIVATE controlled by credits (from L2 not from Sink)
- Add coEnable signal from LinkMonitor (coEnable = syscoreq && syscoack) - Gate TXREQ arbiter output with req_pass = coEnable || is_mmio - Apply bidirectional gating to both valid and ready signals: * txreq.valid = arb.out.valid && req_pass * arb.out.ready = txreq.ready && req_pass - mmio requests are always allowed regardless of coEnable state
* Shadow Buffer(32) in rx channel to receive flit from noc * When Shadow Buffer has > 16 space, reponse lcrdv right after flitv
…rom AsyncBridge" This reverts commit 5f59e1f.
yulightenyu
force-pushed
the
return_lcredit_issue
branch
from
5aa55c5 to
7791c06
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.