refactor(paddr.c): update store_commit_queue_push logic#994
Open
skyhgzsh wants to merge 1 commit intoOpenXiangShan:masterfrom
Open
refactor(paddr.c): update store_commit_queue_push logic#994skyhgzsh wants to merge 1 commit intoOpenXiangShan:masterfrom
skyhgzsh wants to merge 1 commit intoOpenXiangShan:masterfrom
Conversation
skyhgzsh
requested review from
Anzooooo,
cebarobot and
good-circle
as code owners
There was a problem hiding this comment.
Pull request overview
Refactors the difftest store-commit queue encoding in paddr.c, changing how store events are normalized (address alignment), masked, and split before being pushed to the C++ queue. The PR is explicitly marked as a breaking change due to store_queue diff format incompatibility.
Changes:
- Replaces prior store-commit push logic (including misalignment/vector special-casing) with a unified 8-byte-aligned encoding that may split stores across an 8B boundary.
- Introduces
mask_expand()to convert an 8-bit byte mask into a 64-bit per-byte data mask for masking shifted store data. - Adds stricter runtime validation of
len(power-of-two unlesscross_page_store).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
NEMU Performance Results
|
huxuan0307
requested changes
Apr 8, 2026
skyhgzsh
force-pushed
the
skyhgzsh-perf
branch
2 times, most recently
from
355ca1a to
dd287e4
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
NEMU Performance Results
|
NEMU Performance Results
|
skyhgzsh
force-pushed
the
skyhgzsh-perf
branch
2 times, most recently
from
2d4da60 to
83cb867
Compare
NEMU Performance Results
|
NEMU Performance Results
|
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
NEMU Performance Results
|
NEMU Performance Results
|
NEMU Performance Results
|
NEMU Performance Results
|
NEMU Performance Results
|
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
NEMU Performance Results
|
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
skyhgzsh
added a commit
to skyhgzsh/ready-to-run
that referenced
this pull request
Apr 9, 2026
* NEMU commit: de7d035fd308bbd95312d58e4d0fe41b07c4b5ad
* NEMU configs:
* riscv64-xs-ref_defconfig
* riscv64-dual-xs-ref_defconfig
* riscv64-xs-ref-debug_defconfig
* riscv64-dual-xs-ref-debug_defconfig
Including:
* refactor(paddr.c, macro.h): update store_commit_queue_push logic and add new macro([#994](OpenXiangShan/NEMU#994))
skyhgzsh
force-pushed
the
skyhgzsh-perf
branch
2 times, most recently
from
f4a5402 to
dc8aa6c
Compare
NEMU Performance Results
|
NEMU Performance Results
|
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…add new macro * if a committed store crosses a 8 byte boundary, the function store_commit_queue_push() will split the store commit into two parts, and push them into the commit queue separately. * add macro SAFE_BITMASK for generating bitmask safely. * add macro SAFE_BITMASKRANGE for generating range-based bitmask safely. * add macro IS_POW_OF_2 for check if a number is a power of 2. BREAKING CHANGE: store_queue diff is not backward compatible!
skyhgzsh
added a commit
to skyhgzsh/ready-to-run
that referenced
this pull request
Apr 10, 2026
* NEMU commit: de7d035fd308bbd95312d58e4d0fe41b07c4b5ad
* NEMU configs:
* riscv64-xs-ref_defconfig
* riscv64-dual-xs-ref_defconfig
* riscv64-xs-ref-debug_defconfig
* riscv64-dual-xs-ref-debug_defconfig
Including:
* refactor(paddr.c, macro.h): update store_commit_queue_push logic and add new macro([#994](OpenXiangShan/NEMU#994))
skyhgzsh
added a commit
to OpenXiangShan/ready-to-run
that referenced
this pull request
Apr 10, 2026
* NEMU commit: de7d035fd308bbd95312d58e4d0fe41b07c4b5ad
* NEMU configs:
* riscv64-xs-ref_defconfig
* riscv64-dual-xs-ref_defconfig
* riscv64-xs-ref-debug_defconfig
* riscv64-dual-xs-ref-debug_defconfig
Including:
* refactor(paddr.c, macro.h): update store_commit_queue_push logic and add new macro([#994](OpenXiangShan/NEMU#994))
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
NEMU Performance Results
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: store_queue diff is not backward compatible!