fix: add missing PerfCounterOptionsKey parameter#76
Merged
linjuanZ merged 1 commit intoOpenXiangShan:masterfrom Mar 17, 2026
Merged
fix: add missing PerfCounterOptionsKey parameter#76linjuanZ merged 1 commit intoOpenXiangShan:masterfrom
linjuanZ merged 1 commit intoOpenXiangShan:masterfrom
Conversation
The missing parameter caused make test-top-l3 to fail. Add the required configuration fragment to resolve the error.
Yan-Yiming
requested review from
Copilot and
linjuanZ
and removed request for
Copilot
There was a problem hiding this comment.
Pull request overview
Fixes test-top-l3 elaboration by providing the missing configuration fragments (LogUtilsOptionsKey / PerfCounterOptionsKey) required by the OpenLLC test top.
Changes:
- Update
TestTop_L3’s localConfiglambda to usehereso it can referenceOpenLLCParamKey. - Add
LogUtilsOptionsKeyconfiguration derived fromOpenLLCParamKeyfields. - Add
PerfCounterOptionsKeyconfiguration derived fromOpenLLCParamKeyfields.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
linjuanZ
approved these changes
Mar 17, 2026
Yan-Yiming
added a commit
to Yan-Yiming/CoupledL2
that referenced
this pull request
Apr 2, 2026
…han/OpenLLC#76) The missing parameter caused make test-top-l3 to fail. Add the required configuration fragment to resolve the error.
Yan-Yiming
added a commit
to Yan-Yiming/CoupledL2
that referenced
this pull request
Apr 9, 2026
…han/OpenLLC#76) The missing parameter caused make test-top-l3 to fail. Add the required configuration fragment to resolve the error.
Yan-Yiming
added a commit
to Yan-Yiming/CoupledL2
that referenced
this pull request
Apr 9, 2026
…han/OpenLLC#76) The missing parameter caused make test-top-l3 to fail. Add the required configuration fragment to resolve the error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The missing parameter caused make test-top-l3 to fail. Add the required configuration fragment to resolve the error.