Merged
Conversation
poemonsense
approved these changes
Dec 17, 2020
linjuanZ
added a commit
that referenced
this pull request
Jan 16, 2025
* CoupledL2 commit: eeaef66 Including: * fix(TXDAT, RXDAT, MMIOBridge): DataCheck uses odd parity, and support NC (#329) * feat: add Issue C (#333) * feat(l2hint): optimal CustomL1Hint to improve l2hint accuracy (#319) * fix(TXDAT): fix incorrect assignment of CCID (#330) * fix(MSHR): retry immutability for Release transactions (#328) * fix(MSHR): consider WriteEvict* as nested write back (#327) * fix(MSHR): always update meta on ProbeAck TtoB under ```cbo.clean``` (#325) * timing(Slice, BOP): avoid timing path from SRAM to ICG (#321) * SnpStash should probe L1 when L2 cache state is TRUNK (#326) * fix(MSHR): meta write on SnpCleanShared derived Probe toT (#320) * feat(MSHR, MainPipe): support SnpQuery for Issue E.b (#323) * fix(workflow): tar up test results on CI failure (#322) * fix(MSHR): TgtID selection for CompAck of WriteEvictOrEvict (#316) * fix(MSHR): wrongly retried as WriteEvictOrEvict on CMO release (#317) * submodule(Huancun): bump Huancun * feat(TopDown): add l2Miss IO for Top-Down * style(Message): more robust issue isolation (#315) * feat(MSHR): support WriteEvictOrEvict on eviction (#311) * fix(MSHR): always clear meta.dirty on CMO Release (#313) ========== * OpenLLC commit: 0b536490d32657ce4db941dde08fa000699543e8 Including: * submodule(CoupledL2): bump CoupledL2 (#36) * feat: add Issue C (#35) * submodule(CoupledL2): bump CoupledL2 (#34) * fix(RefillUnit): modify cancel condition for refillEntry (#33) * feat(TopDown): add l3Miss IO for Top-Down (#32) * style: more robust issue isolation (#31) * submodule(coupledL2): bump coupledL2 * feat(MainPipe, ResponseUnit): support WriteEvictOrEvict transaction (#30)
Frankslu
pushed a commit
that referenced
this pull request
Jan 14, 2026
… NC (#329) This pr fixes bugs concerning `DataCheck`: * According to the CHI manual, `DataCheck` should use odd parity. Fixed the issue where even parity was incorrectly used in `TXDAT` and `RXDAT`: the parity bit should be obtained by XOR all bits of the data and then XOR the result with 1. * Should use `VecInit` instead of `Cat` to avoid reverse sequence. * In `MMIOBridge`, `DataCheck` operations, which are the same as those in `TXDAT` & `RXDAT`, are added for `NC`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
with parallel helper functions