fix: Save the clock and instruction count for the warmup#586
Merged
poemonsense merged 1 commit intomasterfrom Feb 27, 2025
Merged
fix: Save the clock and instruction count for the warmup#586poemonsense merged 1 commit intomasterfrom
poemonsense merged 1 commit intomasterfrom
Conversation
poemonsense
previously approved these changes
Feb 26, 2025
xiaokamikami
force-pushed
the
fix_wmp
branch
4 times, most recently
from
d23095e to
0d2822b
Compare
poemonsense
reviewed
Feb 27, 2025
src/test/csrc/vcs/vcs_main.cpp
Outdated
| } | ||
|
|
||
| if (need_warmup) { | ||
| need_warmup = false; |
Member
There was a problem hiding this comment.
This line can be removed. Others looks good to me
xiaokamikami
force-pushed
the
fix_wmp
branch
from
0d2822b to
b98e3a5
Compare
poemonsense
approved these changes
Feb 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The clock and instruction counter data should be saved at the time of the warmup to calculate the IPC after the warmup，It also supports recording the warmup data of each core when multiple cores are used，and change the command print prompt when the warmup trigger is triggered to base 10