feat(build): Prepare for XiangShan docker support#615
Merged
poemonsense merged 3 commits intomasterfrom Apr 28, 2025
Merged
Conversation
forever043
changed the title
forever043
force-pushed
the
prep_xs_docker
branch
2 times, most recently
from
59728a5 to
6be4838
Compare
poemonsense
reviewed
Apr 28, 2025
| @date -R | tee -a $(TIMELOG) | ||
| $(TIME_CMD) verilator $(VERILATOR_FLAGS) -Mdir $(@D) $^ $(EMU_DEPS) | ||
| $(TIME_CMD) $(VERILATOR) $(VERILATOR_FLAGS) --Mdir $(@D) $^ $(EMU_DEPS) | ||
| @sed -i -e 's/$(subst /,\/,$(NOOP_HOME))/$$(NOOP_HOME)/g' \ |
Contributor
Author
There was a problem hiding this comment.
- fix wrong
-Mdirto--Mdir(although it work now) - use VERILATOR variable instead of verilator to support override outside
- change abs-path in generated VSimTop.mk to
$(NOOP_HOME)/xxx, then we can move the build directory to other place by reset NOOP_HOME env
all these changes are pre-requirements of docker build support OpenXiangShan/PR#4538
Member
There was a problem hiding this comment.
- change abs-path in generated VSimTop.mk to
$(NOOP_HOME)/xxx, then we can move the build directory to other place by reset NOOP_HOME env
I see. But this would require that NOOP_HOME is always specified, even after verilator exits. I'm not sure if this is OK?
Contributor
Author
There was a problem hiding this comment.
- change abs-path in generated VSimTop.mk to
$(NOOP_HOME)/xxx, then we can move the build directory to other place by reset NOOP_HOME envI see. But this would require that NOOP_HOME is always specified, even after verilator exits. I'm not sure if this is OK?
NOOP_HOME was not required, the abs-path was set as default in VSimTop.mk
e.g.:
NOOP_HOME ?= /xxx/yyy
default: $(NOOP_HOME)/emu
...
poemonsense
approved these changes
Apr 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.