refactor: remove redundant shift 0 in generated code#57
Merged
jaypiper merged 1 commit intoOpenXiangShan:masterfrom Mar 30, 2025
Merged
refactor: remove redundant shift 0 in generated code#57jaypiper merged 1 commit intoOpenXiangShan:masterfrom
jaypiper merged 1 commit intoOpenXiangShan:masterfrom
Conversation
Collaborator
|
why not use fmt::printf instead? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested with make diff dutName={rocket|small-boom|large-boom}
I also want to recommend bumping to C++ 20 so we can use std::format instead. Which can help us get rid of those ugly
c_str().Or, since most format strings is now simplified to sth like "(%s(%s%s %s) %s)", we can also use
+instead of format.