Skip to content

Commit 22a8cec

Browse files
committed
riscv: Fix matrix helper file cleanup issues
Add the missing trailing newlines and clarify that mtilek is tracked in bytes for A/B tile helpers so the comments match the implementation.
1 parent da979d0 commit 22a8cec

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

target/riscv/insn_trans/trans_rvmm.c.inc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -550,4 +550,4 @@ static bool trans_macquire(DisasContext *s, arg_mm_async *a)
550550
return false;
551551
}
552552
return true;
553-
}
553+
}

target/riscv/matrix_helper.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -29,9 +29,9 @@ void helper_msettilen(CPURISCVState *env, target_ulong s1)
2929
/* Matrix Load/Store helpers */
3030
/*
3131
* The v0.6 proposal defines 3 tile shapes (based on C = A x B^T):
32-
* - A tile : mtilem x mtilek (mtilem rows, mtilek elements per row)
33-
* - B tile : mtilen x mtilek
34-
* - C tile : mtilem x mtilen
32+
* - A tile : mtilem x mtilek (mtilem rows, mtilek bytes per row)
33+
* - B tile : mtilen x mtilek (mtilen rows, mtilek bytes per row)
34+
* - C tile : mtilem x mtilen (element counts in both dimensions)
3535
*
3636
* rs1 base address, rs2 row byte stride. Whole-matrix load/store ignores tile
3737
* sizes and uses the full physical register shape (get_mrows x get_rlenb).
@@ -950,4 +950,4 @@ void helper_mfmacc_s_e5(void *md, void *ms1, void *ms2, CPURISCVState *env)
950950
{
951951
/* FP8-E5 FP32 semantics not yet implemented; trap as illegal. */
952952
riscv_raise_exception(env, RISCV_EXCP_ILLEGAL_INST, GETPC());
953-
}
953+
}

0 commit comments

Comments
 (0)