Skip to content

Add source ID landing pages#225

Merged
znichollscr merged 7 commits intomainfrom
source-id-landing-pages
Mar 20, 2025
Merged

Add source ID landing pages#225
znichollscr merged 7 commits intomainfrom
source-id-landing-pages

Conversation

@znichollscr
Copy link
Copy Markdown
Collaborator

@znichollscr znichollscr commented Mar 14, 2025 •
edited
Loading

Description

Closes #209

Checklist

Please confirm that this pull request has done the following:

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 14, 2025

No changes to the database between 'main' branch and 7478886

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 14, 2025

No changes to the database between 'main' branch and cb02414

@znichollscr
Copy link
Copy Markdown
Collaborator Author

znichollscr commented Mar 14, 2025

@sashakames what do you think of these as landing pages and citation entries? x-ref #177 (comment) and #209

sashakames
sashakames approved these changes Mar 18, 2025
View reviewed changes
Copy link
Copy Markdown

@sashakames sashakames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me AFAIK. We can backfill the pages into the "citation_url" field in the ESGF index records

@znichollscr znichollscr force-pushed the source-id-landing-pages branch from cb02414 to ddee68b Compare March 20, 2025 14:36
@znichollscr znichollscr force-pushed the source-id-landing-pages branch from ddee68b to 99ae4ab Compare March 20, 2025 14:36
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 20, 2025

No changes to the database between 'main' branch and ddee68b

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 20, 2025

No changes to the database between 'main' branch and 99ae4ab

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 20, 2025

No changes to the database between 'main' branch and c91512f

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 20, 2025

No changes to the database between 'main' branch and 647542d

@znichollscr
Copy link
Copy Markdown
Collaborator Author

znichollscr commented Mar 20, 2025

Looks great to me AFAIK. We can backfill the pages into the "citation_url" field in the ESGF index records

Perfect thanks. I'll merge and let's see how it goes.

@znichollscr znichollscr merged commit 12e8ab6 into main Mar 20, 2025
8 checks passed
@znichollscr znichollscr deleted the source-id-landing-pages branch March 20, 2025 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@sashakames sashakames sashakames approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Generate citation info for source IDs on registration

2 participants

@znichollscr @sashakames
⚡