Skip to content

Qt: show full game titles in grid view#14092

Open
samy-bennabi wants to merge 1 commit intoPCSX2:masterfrom
samy-bennabi:Qt-show-full-game-titles
Open

Qt: show full game titles in grid view#14092
samy-bennabi wants to merge 1 commit intoPCSX2:masterfrom
samy-bennabi:Qt-show-full-game-titles

Conversation

@samy-bennabi
Copy link
Copy Markdown

@samy-bennabi samy-bennabi commented Mar 5, 2026

Description of Changes

Added a toggle to show full game title by wrapping the text on multiple lines using Qt::TextWordWrap.
I added the new toggle wherever the show game titles toggle was, in the toolbar and under the View menu.
I used the price-tag-2-line icon from Remix Icon as it seemed most appropriate with its 2 lines.

Rationale behind Changes

Some games with longer benefit from having them fully visible, especially when multiple discs are present.

Toggle off:
image

Toggle on:
image

Armored Core - Nexus being a prime example here.

Fixes #8551

Suggested Testing Steps

I tested resizing the window, using different zoom levels, and toggling both show titles and show full titles.
Only tested on Linux (Fedora 43).

Did you use AI to help find, test, or implement this issue or feature?

Yes, was stuck getting the text height right because I didn't understand how Qt handles text well enough.
used claud code that suggested using:

const QFontMetrics fm(font);
int maxHeight = fm.height();
const QRect bound = fm.boundingRect(QRect(0, 0, textWidth, 0), Qt::TextWordWrap | Qt::AlignHCenter, title);

I only implemented it after making sure it's good.

Added UI element with new icon and a calculation of max text height.
@github-actions github-actions bot added the GUI/Qt label Mar 5, 2026
Copy link
Copy Markdown
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting a contribution to PCSX2

As this is your first pull request, please be aware of the contributing guidelines.

Additionally, as per recent changes in GitHub Actions, your pull request will need to be approved by a maintainer before GitHub Actions can run against it. You can find more information about this change here.

Please be patient until this happens. In the meantime if you'd like to confirm the builds are passing, you have the option of opening a PR on your own fork, just make sure your fork's master branch is up to date!

@samy-bennabi samy-bennabi changed the title Qt: show full game titles in grid mode Qt: show full game titles in grid view Mar 5, 2026
@GitHub-Khi
Copy link
Copy Markdown

I did not believe that this would ever come true. So now i have high hopes for my other requests regarding the UI. ^-^

@kamfretoz
Copy link
Copy Markdown
Contributor

Any updates on this? (Was wondering since the PR is drafted)

@samy-bennabi
Copy link
Copy Markdown
Author

Any updates on this? (Was wondering since the PR is drafted)

On my side I haven't done much since. I tried to make the same changes in big picture mode with no success, any help is welcome as I'm new to Qt.
I made a draft PR following the contribution guidelines. Let me know if I should make it ready for review (it's tested and working).

@kamfretoz
Copy link
Copy Markdown
Contributor

Let me know if I should make it ready for review (it's tested and working).

Yes please mark it as ready for review so others can test it, we can leave FSUI for the future.

@samy-bennabi samy-bennabi marked this pull request as ready for review March 22, 2026 19:15
@Mrlinkwii Mrlinkwii added this to the Release 2.8 milestone Mar 22, 2026
@Mrlinkwii
Copy link
Copy Markdown
Contributor

would it be a good idea just all the time just show full game titles ? opinions?

@kamfretoz
Copy link
Copy Markdown
Contributor

would it be a good idea just all the time just show full game titles ? opinions?

I fully agree


{
const int cover_width = static_cast<int>(static_cast<float>(SIZE_HINT_WIDTH) * m_cover_scale);
const int cover_height = static_cast<int>(static_cast<float>(SIZE_HINT_HEIGHT) * m_cover_scale);
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use tabs for indenting.

@F0bes
Copy link
Copy Markdown
Member

F0bes commented Mar 29, 2026

would it be a good idea just all the time just show full game titles ? opinions?

Then some people will want the old behaviour. Having the option I think is fine.

@kamfretoz
Copy link
Copy Markdown
Contributor

kamfretoz commented Mar 30, 2026

Then some people will want the old behaviour. Having the option I think is fine.

Obligatory XKCD
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request]: Game Grid - Show full game titles

5 participants