Deps: Update rapidyaml to v0.11.1 and move out of tree#14207
Merged
F0bes merged 1 commit intoPCSX2:masterfrom Apr 3, 2026
Merged
Deps: Update rapidyaml to v0.11.1 and move out of tree#14207F0bes merged 1 commit intoPCSX2:masterfrom
F0bes merged 1 commit intoPCSX2:masterfrom
Conversation
52ccc5a to
a0a7759
Compare
a0a7759 to
2386082
Compare
Member
In that case, would you mind keeping the old callback code in with a |
Member
Author
|
I think I'll wait for some of the existing deps PRs to go in. So I need to do less rebasing. |
2386082 to
c2bb0fb
Compare
f0a31f3 to
169a0ba
Compare
aed4464 to
006d7d0
Compare
006d7d0 to
c4c471f
Compare
JordanTheToaster
approved these changes
Mar 30, 2026
ce1fef5 to
8636022
Compare
8636022 to
310287b
Compare
TellowKrinkle
approved these changes
Mar 31, 2026
Mrlinkwii
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Update rapidyaml to v0.11.1, and move it out of tree.
Rationale behind Changes
I was asked to help with updating this.
With this update the API for error handling has changed, so it required some changes in common/YAML.cpp.
I've made it so that RapidYAML is built using the dependencies build scripts since the existing build setup we had made it annoying to update. We were using our own custom build scripts since we needed it to be buildable with MSBuild as well as CMake. RapidYAML's code relies on multiple levels of submodules for its dependencies, so this made figuring out what files we needed confusing.
Packagers will need to add RapidYAML as a dependency of PCSX2 (v0.10.0 should still work).
Suggested Testing Steps
Try loading folder memory cards and the game DB. Try corrupting these YAML files and seeing if the error message is as expected. Test on Windows.
Did you use AI to help find, test, or implement this issue or feature?
No.