Skip to content

Deps: Update rapidyaml to v0.11.1 and move out of tree#14207

Merged
F0bes merged 1 commit intoPCSX2:masterfrom
chaoticgd:update_yaml_library
Apr 3, 2026
Merged

Deps: Update rapidyaml to v0.11.1 and move out of tree#14207
F0bes merged 1 commit intoPCSX2:masterfrom
chaoticgd:update_yaml_library

Conversation

@chaoticgd
Copy link
Copy Markdown
Member

@chaoticgd chaoticgd commented Mar 25, 2026

Description of Changes

Update rapidyaml to v0.11.1, and move it out of tree.

Rationale behind Changes

I was asked to help with updating this.

With this update the API for error handling has changed, so it required some changes in common/YAML.cpp.

I've made it so that RapidYAML is built using the dependencies build scripts since the existing build setup we had made it annoying to update. We were using our own custom build scripts since we needed it to be buildable with MSBuild as well as CMake. RapidYAML's code relies on multiple levels of submodules for its dependencies, so this made figuring out what files we needed confusing.

Packagers will need to add RapidYAML as a dependency of PCSX2 (v0.10.0 should still work).

Suggested Testing Steps

Try loading folder memory cards and the game DB. Try corrupting these YAML files and seeing if the error message is as expected. Test on Windows.

Did you use AI to help find, test, or implement this issue or feature?

No.

@github-actions github-actions bot added Build | Project System Dependencies Pull requests that update a dependency file labels Mar 25, 2026
@chaoticgd chaoticgd force-pushed the update_yaml_library branch 2 times, most recently from 52ccc5a to a0a7759 Compare March 25, 2026 00:42
@chaoticgd chaoticgd marked this pull request as draft March 25, 2026 00:56
@chaoticgd chaoticgd force-pushed the update_yaml_library branch from a0a7759 to 2386082 Compare March 25, 2026 01:07
@TellowKrinkle
Copy link
Copy Markdown
Member

Update: I want to try to build this with the dependencies build script instead

In that case, would you mind keeping the old callback code in with a #if RYML_VERSION_MAJOR > 0 || RYML_VERSION_MINOR >= 11? Due to the API breaks, Fedora won't be updating to 0.11 until F44 and I'd rather not have to keep patching my local tree.

@chaoticgd
Copy link
Copy Markdown
Member Author

I think I'll wait for some of the existing deps PRs to go in. So I need to do less rebasing.

@Mrlinkwii Mrlinkwii added this to the Release 2.8 milestone Mar 26, 2026
@chaoticgd chaoticgd force-pushed the update_yaml_library branch from 2386082 to c2bb0fb Compare March 29, 2026 17:46
@chaoticgd chaoticgd force-pushed the update_yaml_library branch 5 times, most recently from f0a31f3 to 169a0ba Compare March 29, 2026 19:07
@chaoticgd chaoticgd changed the title 3rdparty: Update rapidyaml and fast_float 3rdparty: Update rapidyaml to v0.11.1 Mar 29, 2026
@chaoticgd chaoticgd changed the title 3rdparty: Update rapidyaml to v0.11.1 3rdparty: Update rapidyaml to v0.11.1 and move out of tree Mar 29, 2026
@chaoticgd chaoticgd force-pushed the update_yaml_library branch 3 times, most recently from aed4464 to 006d7d0 Compare March 29, 2026 20:23
@chaoticgd chaoticgd marked this pull request as ready for review March 29, 2026 20:45
@chaoticgd chaoticgd force-pushed the update_yaml_library branch from 006d7d0 to c4c471f Compare March 30, 2026 19:12
@chaoticgd chaoticgd changed the title 3rdparty: Update rapidyaml to v0.11.1 and move out of tree Deps: Update rapidyaml to v0.11.1 and move out of tree Mar 30, 2026
@chaoticgd chaoticgd force-pushed the update_yaml_library branch 2 times, most recently from ce1fef5 to 8636022 Compare March 31, 2026 18:59
@chaoticgd chaoticgd force-pushed the update_yaml_library branch from 8636022 to 310287b Compare March 31, 2026 19:55
Copy link
Copy Markdown
Contributor

@kamfretoz kamfretoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still works on Arch

@F0bes F0bes merged commit 0beb18c into PCSX2:master Apr 3, 2026
14 checks passed
@chaoticgd chaoticgd deleted the update_yaml_library branch April 4, 2026 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Build | Project System Dependencies Pull requests that update a dependency file requires-win-deps-build

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants