GameList: Replace [ and ] with '{{' and '}}' to fix custom attributes#14227
Open
GameList: Replace [ and ] with '{{' and '}}' to fix custom attributes#14227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Should fix #12217
Whenever the path has [ or ] in the name, the custom attributes ini gets confused since [ and ] and used to denote ini sections.
Technically, if someone has the exact same file, but manually set [ and ] to be {{ and }}, both files will share custom attributes (hence why I didn't just do { and }).
The alternative would be to URL encode (We already have that in our Path namespace), but this would break existing configurations. I think this is the lesser of two evils?
Rationale behind Changes
Some people like having square brackets in their ISO names, this bug prevented them from setting custom titles or regions for those files.
Suggested Testing Steps
Try assigning a custom title or region to a game whose files (or directory) has square brackets in the name.
Did you use AI to help find, test, or implement this issue or feature?
It told me to hash it. No thanks