GS/GL/DX11: Backport multidraw fb copy from DX11 to GL, and some DX11 cleanup.#14243
Merged
lightningterror merged 4 commits intomasterfrom Apr 4, 2026
Merged
GS/GL/DX11: Backport multidraw fb copy from DX11 to GL, and some DX11 cleanup.#14243lightningterror merged 4 commits intomasterfrom
lightningterror merged 4 commits intomasterfrom
Conversation
lightningterror
force-pushed
the
gs_gl_multidraw_fb_copy
branch
from
5eb24d8 to
bd78b76
Compare
Contributor
If multidraw FB copy is enabled, we could do copies on the depth buffer directly (instead of depth as RT), so that part could also be backported from DX11. Of course, the depth feedback mode might have to be overridden in the feature check, if it's enabled. |
lightningterror
force-pushed
the
gs_gl_multidraw_fb_copy
branch
from
bd78b76 to
0c89542
Compare
Contributor
Author
|
Done, backported the changes. |
TJnotJT
reviewed
Apr 3, 2026
lightningterror
force-pushed
the
gs_gl_multidraw_fb_copy
branch
from
0c89542 to
8778fc9
Compare
TJnotJT
reviewed
Apr 3, 2026
lightningterror
force-pushed
the
gs_gl_multidraw_fb_copy
branch
2 times, most recently
from
c4160dc to
b562ac7
Compare
lightningterror
changed the title
Remove skip first barrier check, rely on the one barrier parameter being set to false. Other misc cleanup.
Will be used when GL_ARB_texture_barrier isn't supported. Can also be used for Depth feedback loops.
lightningterror
force-pushed
the
gs_gl_multidraw_fb_copy
branch
from
b562ac7 to
8f1f631
Compare
TJnotJT
approved these changes
Apr 4, 2026
Contributor
TJnotJT
left a comment
TJnotJT
left a comment
There was a problem hiding this comment.
Changes look good, haven't tested.
Contributor
Author
|
Dump run on gl is fine, also smoke tested some dumps that need sw blend and depth feedback and they work on mesa. Gonna merge since it should be fine, I also have other pending changes and open prs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
GS/DX11: Cleanup some multidraw fb copy code.
Remove skip first barrier check, rely on the one barrier parameter being set to false. Other misc cleanup.
GS/GL: Backport multidraw fb copy from DX11.
Will be used when GL_ARB_texture_barrier isn't supported.
Can also be used for Depth as RT feedback loops.
GS/DX11: Check if Depth feedback is enabled before making a copy.
GS/GL: Backport multidraw fb copy for depth feedbacks.
Rationale behind Changes
Fallback method when texture barriers aren't supported, alternative accuracy means.
Suggested Testing Steps
Needs #14234 merged first, then do the same testing posted in that pr using the dumps and mesa llvmpipe sw renderer.
Did you use AI to help find, test, or implement this issue or feature?
No.