[obsolete] DF/091: safe dataset metadata update#245
Open
mgolosova wants to merge 9 commits intopyDKB-storagesfrom
Open
[obsolete] DF/091: safe dataset metadata update#245mgolosova wants to merge 9 commits intopyDKB-storagesfrom
mgolosova wants to merge 9 commits intopyDKB-storagesfrom
Conversation
If `--es-config FILE` parameter is specified, use DKB ES storage as a backup metadata source in case that in primary source (Rucio) information was removed. Information from Rucio is removed together with the dataset, so if Rucio says that dataset is deleted (or not found), the stage can query internat DKB storage (ES) to get missed information. This functionality is mostly required for "archived" data reprocessing (when we change the ETL process or recover missed records).
This branch requires the new functionality, added to the pyDKB library.
Configuration parameters, started with '__', won't be logged.
Without it we won't see in the log those parameters that have default values, if they are missed in the user passed config.
Move metadata "update" with info from ES to a separate function.
mgolosova
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Status: obsolete
The PR is obsolete but not closed yet: need to check if #253 (merged) does what this PR tried to achieve.
Update: #253 is about
data4es-startitself, while for the Stage 091 #320 should do the trick.Original description
Running stage 091 with
--es-config path/to/configallows stage to check ES@DKB for metadata that were already removed from Rucio together with the datasets.There is still a room for improvements, so
[WIP].And some changes are clearly belong to #244, so...
(Waits for #244.)(obsolete)Waits for #320.