[obsolete] DF/095: safe dataset metadata update#246
Open
mgolosova wants to merge 4 commits into91-ds-safefrom
Open
[obsolete] DF/095: safe dataset metadata update#246mgolosova wants to merge 4 commits into91-ds-safefrom
mgolosova wants to merge 4 commits into91-ds-safefrom
Conversation
There can possibly be different functions, useful for some specific
operations. It is possible to keep them all in the individual files, but
it is not very comfortable to use (one have to type something like
`from pyDKB.common.my_function_name import my_function_name`, or in
`__init__` file have a list of imports like this:
`from my_function_name import my_function_name`).
So I think it will be fine to put them all to a common file ('utils' or
'misc' or whatever) and use like `from pyDKB.common.utils import
my_function_name`). Looks a little better (for me, at least).
Function like this seem to be needed in multiple places, so why not to have it in the common library.
If `--es-config FILE` parameter is specified, use DKB ES storage as a backup metadata source in case that in primary source (AMI) information was removed. I am not sure under what curcumstances information can be removed from AMI, so for now we just check if there are empty/missed fields in the data taken from AMI and then, if such firlds found, check ES for (possibly) already known values. The problem is that there are quite a lot of "missed" values, so almost for every record we have to check both AMI and ES. Maybe there is more delicate trigger, like "No data at all", or "if dataset property 'deleted' is set to True", or... Or maybe AMI just doesn't remove data at all?..
In theory it should make the request slightly faster.
mgolosova
changed the title
This was referenced Apr 28, 2019
mgolosova
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR is obsolete but not closed yet: need to check if #253 does what this PR tried to achieve.
Update Stage 95 to allow safe metadata update (with ES@DKB as a 'backup' storage, used when some metadata are missed in AMI).
[WIP] is because of pyDKB changes: not sure if they belong this PR.
And about a9d10ac commit log: testing shows that metadata in AMI do change from time to time, and sometimes they are removed.
ToDo:
read_es_config()should be turned intoread_sh_config()or something?Waits for #244