add support for --cpu-type when creating VM#146
Open
Pr0Ger wants to merge 1 commit intoParallels:mainfrom
Open
add support for --cpu-type when creating VM#146Pr0Ger wants to merge 1 commit intoParallels:mainfrom
Pr0Ger wants to merge 1 commit intoParallels:mainfrom
Conversation
Pr0Ger
requested review from
alevlasu,
bineesh-n,
cjlapao and
sai-kumar-peddireddy
as code owners
|
I'd definitely like to see this merged, however I think the rosetta ones run faster if I'm not mistaken. Unfortunately it's not a true environment though so this (meaning this PR) is better than not supporting x86 at all IMO. |
Collaborator
|
@Pr0Ger Thanks for the PR but this is per design, if the host is ARM it will build ARM vms, if the host is x64 it will build x64 vms. We have a technical preview were we use emulation to run x64 machines on ARM, but this is still technical preview and therefore not fully available and we do not know if it will ever be. So I will leave this open in case the emulation becomes GA but until then we will keep the default behavior. Thansk |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've tried to locally build an image to use in a cloud provider, but I figured out I can't do it since this plugin only allows creating ARM VMs (even though Parallels support running x86 VMs). This PR fixes it by allowing the override of --cpu-type when creating a VM.
One moment: since HWConfig is shared between ISO and IPSW builders, it was also added to the second one (even though it doesn't make sense since IPSW is only for macOS images built for ARM processors). I'm not sure what to do with it: should I add some extra validation to disallow passing x86 in this builder, or should I separate this parameter out of HWConfig to make it present only for the ISO builder?