Conversation
|
I have same issue. This PR needs to merged asap. Thanks @h2zero |
|
It would be really helpful to have this merged. Right now I have to manually edit the source file for each project every time the library updates. I would rather not have to fork a custom version of the library just to add this line of code... 🤔 Is there anything holding this up from being merged? |
|
Does this work for everyone? Usually this type of change involves an ifdef check to include the proper header based on the version used. If I merge this, does it break for everyone using the old version? |
|
Hi Paul, Thanks for looking at this! I can't speak for everyone, but in my environment I am using the following in PlatformIO/PIOArduino: [env:esp32-s2-mini]
platform = https://github.com/pioarduino/platform-espressif32/releases/download/51.03.07/platform-espressif32.zip
board = lolin_s2_mini
framework = arduinoThis release is based on IDF In my present build environment, I can use either of the following two lines to resolve the compile error: #include <soc/gpio_struct.h>
#include <hal/gpio_ll.h>The second line After some more troubleshooting today, I think I have potentially uncovered the underlying issue for me. For some reason, it appears that the |
|
For reference, I have created a post on the PlatformIO forum to address the issue with the broken library on the PlatformIO registry. https://community.platformio.org/t/onewire-2-3-8-from-registry-missing-important-line-of-code-from-github-release/48183 |
|
FYI: PlatformIO was able to update their library version to match the files under the current release tag. (Evidently changes were made after the release tag was published, and were not picked up by the automated updater because the version number had not changed.) See the above link for details. This fixes the compile issue for me, and allows me to build my projects using the current |
Fixes the GPIO definition error for esp32 with IDF > v5.