Open
Conversation
…ibrary Registry manifest file Signed-off-by: Roman3349 <ondracek.roman@centrum.cz>
Add information about library to @platformio Library Registry manifest file
from 5186 / 396 byte to 5160 / 395 byte on atmega with ds18x20 example
Author
|
Hi Paul, it is hard to guess your thoughts when you say nothing at all.
|
nomis
reviewed
Sep 29, 2019
| /// | ||
| /// \return true = a device responds with a presence pulse. | ||
| /// false = there is no device or the bus is shorted or otherwise held low for more than 250uS | ||
| bool reset(); |
There was a problem hiding this comment.
This has the same problem as the original version (#79). You can't tell the difference between no devices and a shorted bus.
Author
There was a problem hiding this comment.
ok, it could be changed easily but brings one more comparison. and it will break old code. most codebases will only test for non-zero. On the other hand - a major version change should be allowed to break code (with proper documentation).
the most elegant solution (so old code still works) would be to add a register for error-codes that could be checked.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hi paul, i know you only anticipate PR for new hardware support because you say the lib has "very mature code", but this statement is simply not true. over the years it became a big patchwork of ancient or even useless code. there were several bugs to find. the most obvious one is in the bus-power feature. the function write_bit() always powers the bus without permission. I modernized and extended the interface of the lib without breaking old code. i did tests on several platforms. see list of changes below.
where do you see problems in merging this PR?
I would like to co-maintain the onewire-lib with you. Currently I have rebuild and maintained the https://github.com/orgua/OneWireHub project for emulating slave-devices and i would like to apply my experiences to the onewire-master-lib.
changes i made so far: