Update feedback_accumulator calculation for audio to use AUDIO_SAMPLE_RATE_EXACT#797
Open
bthayer3 wants to merge 1 commit intoPaulStoffregen:masterfrom
Open
Update feedback_accumulator calculation for audio to use AUDIO_SAMPLE_RATE_EXACT#797bthayer3 wants to merge 1 commit intoPaulStoffregen:masterfrom
bthayer3 wants to merge 1 commit intoPaulStoffregen:masterfrom
Conversation
|
FYI, a similar change is lined up in this branch along with a bunch of other fixes for multi-channel USB Audio: https://github.com/h4yn0nnym0u5e/cores/tree/alex6679/add-multi-channel-usb |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found this formula was mentioning 44.1 kHz which could be improved by referencing the exact variable. With this change,
feedback_accumulatorvalue is more dynamic and respects changes to AUDIO_SAMPLE_RATE_EXACT.Note I only am updating Teensy 4 version. I don't know the formula used for Teensy 3 version; I am not sure of the formula for this and how 185042824 was determined.