Handle directories permission denied error in drop privs mode#2291
Merged
Conversation
7 tasks
2f981a8 to
1f37a2d
Compare
jhiemstrawisc
requested changes
May 8, 2025
- Use xrdhttp-pelican to move them into the directories owned by xrootd user - The `SelfTestFileCopy` function has been generalized and renamed to `FileCopyToXrootdDir`. This enhanced function now leverages the xrdhttp-pelican plugin to support a wider range of file copy operations into XRootD-owned directories
… a cross-platform way
Contributor
Author
|
Hey @jhiemstrawisc, when you re-review this PR, I'd recommend taking a commit-by-commit approach for the last three commits, rather than viewing the entire diff at once. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is built on top of #2120, which should be reviewed first.
During the development of the above PR, I notice there are several other permissions denied errors happened on several directories/locations, as below:
All of them except the last one are resolved in this PR - I didn't fix the last one because it is not urgent and xrootd already has a purge mechanism to deal with test files cleanup - I created a separate issue for this problem #2265
How to test
If you are on a fresh container, spin up all four Pelican services as usual to set up the initial configs. Then shut them down and restart Pelican services in drop privs mode by setting the following configs in
pelican.yamlCheck the logging, search for "permissions denied". There should not be any result except the "cache director-based health test clean up .... permission denied". Also consider doing other basic tests.