Dev QOL Update#2310
Merged
Merged
Conversation
- Add ability for dev goreleaser file to constrain the binaries that are built - Fixed Makefile so the website-build step doesn't rely on a file that is symlinked in the step before but rather relies on the source of that file
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR improves the developer experience by updating the goreleaser configuration for development builds and refining the Makefile to correctly trigger website rebuilds with proper source file dependency management.
- Reduced and consolidated file inclusion for website rebuild triggers.
- Added an informational log message to aid in debugging rebuild triggers.
- Introduced a new target "pelican-dev-build" to use a dedicated goreleaser configuration for development.
Comments suppressed due to low confidence (1)
Makefile:125
- [nitpick] The echo message in the 'pelican-dev-build' target does not reflect the 'dev' qualifier in the target name. Consider updating the message to 'PELICAN DEV BUILD' for clarity.
@echo PELICAN BUILD
Contributor
Author
|
@matyasselmeci Assume you have the most Makefile context to review this. |
Prevents us from catching any file path that contains out and now only catches files in the out dir
Contributor
|
Is there any documentation you could mention this new feature in? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows the inclusion of a goreleaser file usable with
make pelican-dev-build.