Skip to content

Dev QOL Update#2310

Merged
CannonLock merged 3 commits into
mainfrom
dev-qol
Jun 4, 2025
Merged

Dev QOL Update#2310
CannonLock merged 3 commits into
mainfrom
dev-qol

Conversation

@CannonLock

Copy link
Copy Markdown
Contributor
  • Add ability for dev goreleaser file to constrain the binaries that are built
  • Fixed Makefile so the website-build step doesn't rely on a file that is symlinked in the step before but rather relies on the source of that file

Allows the inclusion of a goreleaser file usable with make pelican-dev-build.

# ***************************************************************
#
#  Copyright (C) 2024, Pelican Project, Morgridge Institute for Research
#
#  Licensed under the Apache License, Version 2.0 (the "License"); you
#  may not use this file except in compliance with the License.  You may
#  obtain a copy of the License at
#
#     http://www.apache.org/licenses/LICENSE-2.0
#
#  Unless required by applicable law or agreed to in writing, software
#  distributed under the License is distributed on an "AS IS" BASIS,
#  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
#  See the License for the specific language governing permissions and
#  limitations under the License.
#
# ***************************************************************

project_name: pelican
version: 2

release:
  prerelease: true
before:
  hooks:
    - go mod tidy
    - go generate ./...
    - make web-build
builds:
  - env:
      - CGO_ENABLED=0
    goos:
      - linux
    goarch:
      - arm64
    id: "pelican"
    dir: ./cmd
    binary: pelican
    tags:
      - forceposix
    ldflags:
      - -s -w -X github.com/pelicanplatform/pelican/version.commit={{.Commit}} -X github.com/pelicanplatform/pelican/version.date={{.Date}} -X github.com/pelicanplatform/pelican/version.builtBy=goreleaser -X github.com/pelicanplatform/pelican/version.version={{.Version}}
checksum:
  name_template: "checksums.txt"
snapshot:
  version_template: "{{ .Version }}"
changelog:
  sort: asc
  filters:
    exclude:
      - "^docs:"
      - "^test:"
      - Merge pull request
      - Merge branch

- Add ability for dev goreleaser file to constrain the binaries that are built
- Fixed Makefile so the website-build step doesn't rely on a file that is symlinked in the step before but rather relies on the source of that file
@CannonLock CannonLock requested a review from Copilot May 13, 2025 17:50

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR improves the developer experience by updating the goreleaser configuration for development builds and refining the Makefile to correctly trigger website rebuilds with proper source file dependency management.

  • Reduced and consolidated file inclusion for website rebuild triggers.
  • Added an informational log message to aid in debugging rebuild triggers.
  • Introduced a new target "pelican-dev-build" to use a dedicated goreleaser configuration for development.
Comments suppressed due to low confidence (1)

Makefile:125

  • [nitpick] The echo message in the 'pelican-dev-build' target does not reflect the 'dev' qualifier in the target name. Consider updating the message to 'PELICAN DEV BUILD' for clarity.
@echo PELICAN BUILD

Comment thread Makefile
@CannonLock CannonLock requested review from matyasselmeci and removed request for Copilot May 13, 2025 17:50
@CannonLock

Copy link
Copy Markdown
Contributor Author

@matyasselmeci Assume you have the most Makefile context to review this.

Comment thread Makefile Outdated
Comment thread Makefile Outdated
Prevents us from catching any file path that contains out and now only catches files in the out dir
@CannonLock CannonLock requested a review from matyasselmeci May 19, 2025 18:26
@CannonLock CannonLock added the internal Internal code improvements, not user-facing label May 19, 2025
@CannonLock CannonLock linked an issue May 19, 2025 that may be closed by this pull request

@matyasselmeci matyasselmeci left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matyasselmeci

Copy link
Copy Markdown
Contributor

Is there any documentation you could mention this new feature in?

@CannonLock CannonLock merged commit 9a39530 into main Jun 4, 2025
13 of 14 checks passed
@CannonLock CannonLock deleted the dev-qol branch September 15, 2025 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal Internal code improvements, not user-facing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fixup Pelican build for Dev Env

3 participants