Build a "debug" RPM for the Pelican client#2317
Merged
Merged
Conversation
7 tasks
Contributor
|
@brianhlin Do you want the 7.16.1 client on CHTC? Or should this be targetted for 7.15? |
Contributor
|
@timtheisen we need a 7.15.x client since we have two outstanding caches on 7.15 |
Contributor
|
This pull request is against main, which implies 7.16. @brianaydemir probably needs to make a new PR against a 7.15 branch. |
Contributor
Author
|
PR's against I don't know the exact process for how these things get back ported. @jhiemstrawisc? We could also probably use some sort of plan for keeping that hard-coded version in |
matyasselmeci
approved these changes
May 16, 2025
Member
|
If you want this backported, add the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to ensure that Pelican's release process yields an RPM (yes, specifically an RPM) whose
pelicanbinary includes sufficient information to be run successfully under a debugger, such as Delve.Some notes about the changes here:
I am taking advantage of YAML "anchors" and "aliases" to avoid duplicating raw YAML text. Admittedly, this depends on support for merge keys, but I've yet to encounter a YAML parser that behaves in an unexpected manner when presented with such.
I've edited some of the lists in
.goreleaser.ymlso that theidkey appears towards the top of each list element. It would seem that GoReleaser requires that these keys be unique, so burying them in the depths of a list element feels unhelpful.GoReleaser would seem to make it all-but-impossible to specify that the "debug" RPM provides a specific version of "pelican". While not ideal, I've decided that the simplest solution for the wider ecosystem is to claim that the debug RPM provides
pelican, and leave it to end-users/consumers to sort out version constraints.