Add health status to server ads and use to report high concurrency in origins/caches#2338
Merged
Merged
Conversation
jhiemstrawisc
added
enhancement
Member
Author
|
@patrickbrophy I'm hoping you can take a look at the prometheus bits in this. In particular, I wasn't totally sure which metric I actually needed. I know the config I compare the scraped value against is fed to the throttle plugin, which helped me narrow things down to those metrics. I couldn't find documentation to understand the differences between the options I had there, however. |
h2zh
requested changes
May 22, 2025
Since whether or not we need a token can be determined through our param package by inspecting the value of 'Monitoring.PromQLAuthorization', we can move conditional token generation completely into the function itself.
It ocurred to me that this was another value we should move into the function body for a few reasons... It's not really valid to pass values like "director/Director", "Cache", or "Origin" through the function signature. The JWT RFC states that token subjects MUST either be unique within their issuer scope or globally unique, so lumping all "Origin"s and "Director"s into a single string is a violation. Moreover, the function name implies we already know both the sender and receiver of the token -- "me". We now simply grabs the server's external Web URL inside the function and use that to satisfy both subject uniqueness and standardize on the values that are used.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does two primary things:
This does not implement any special logic Director side to use that information.