Filter OSS Packets#2370
Merged
jhiemstrawisc merged 6 commits intoJun 13, 2025
Merged
Conversation
bbockelm
requested changes
May 31, 2025
bbockelm
left a comment
bbockelm
left a comment
Collaborator
There was a problem hiding this comment.
This only tests if the last event in the list is an expected OSS event type.
If the server timing is such that the unknown event is always last, then the desired OSS event will always be ignored.
Probably need to change things so you iterate backward through the packets.
patrickbrophy
force-pushed
the
filter-oss-packets
branch
from
0a70cb7 to
d3cab39
Compare
jhiemstrawisc
requested changes
Jun 13, 2025
patrickbrophy
force-pushed
the
filter-oss-packets
branch
from
d24c9d2 to
2019a1a
Compare
jhiemstrawisc
added
cache
jhiemstrawisc
approved these changes
Jun 13, 2025
jhiemstrawisc
left a comment
jhiemstrawisc
left a comment
Member
There was a problem hiding this comment.
Changes look good to me, thanks!
Let's double check that the currently-failing test is just a fluke (looks unrelated, but I'd like to double check).
Before you merge, can you fix the "PR Validation" test by creating/linking an issue that describes what symptoms this extra handling was solving?
Member
|
Using super powers to merge this -- I believe Patrick has addressed BrianB's comments. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an allow list to the OSS packet handler so that we can filter packets that are disallowed from being processed into metrics. If we want to add another event we can just update the allow list.