Skip to content

OSDF systemd services: use pelican-server everywhere#2478

Merged
matyasselmeci merged 1 commit into
PelicanPlatform:mainfrom
matyasselmeci:pr/osdf-use-pelican-server
Jul 14, 2025
Merged

OSDF systemd services: use pelican-server everywhere#2478
matyasselmeci merged 1 commit into
PelicanPlatform:mainfrom
matyasselmeci:pr/osdf-use-pelican-server

Conversation

@matyasselmeci

@matyasselmeci matyasselmeci commented Jul 9, 2025

Copy link
Copy Markdown
Contributor

This avoids reliance on the magic config from the osdf binary.

This avoids reliance on the magic config from the `osdf` binary.
Fixes PelicanPlatform#2464.
@matyasselmeci matyasselmeci added this to the v7.18 milestone Jul 9, 2025
@matyasselmeci matyasselmeci added enhancement New feature or request director Issue relating to the director component registry Issue relating to the registry component labels Jul 9, 2025
@matyasselmeci matyasselmeci linked an issue Jul 9, 2025 that may be closed by this pull request
2 tasks
@patrickbrophy patrickbrophy requested a review from brianhlin July 10, 2025 20:33

@brianhlin brianhlin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matyasselmeci matyasselmeci merged commit c2defd1 into PelicanPlatform:main Jul 14, 2025
26 of 30 checks passed
@matyasselmeci matyasselmeci deleted the pr/osdf-use-pelican-server branch July 14, 2025 23:07
@jhiemstrawisc

Copy link
Copy Markdown
Member

Does this mean we're using the pelican-server binary for services other than the cache?

@brianhlin

Copy link
Copy Markdown
Contributor

@jhiemstrawisc

Copy link
Copy Markdown
Member

Roping in @h2zh on this -- we just merged a change that enables CGO in the pelican-server binary, a decision that was predicated on our belief the pelican-server binary was not in use outside the controlled environment of our cache images (see issue #2485 and corresponding PR #2488).

I don't have a full grasp of potential consequences here, but I think enabling CGO means we lose having a static binary (haven't confirmed this) and need to worry more about distribution.

@jhiemstrawisc

Copy link
Copy Markdown
Member

I'll follow up with a note that we do eventually want pelican-server to be used for all servers, but we didn't know that was already happening, and we thought we were kicking this CGO can down the road to figure out at a later time.

@h2zh

h2zh commented Jul 16, 2025

Copy link
Copy Markdown
Contributor

One concern I have for this change is - now with CGO_ENABLED=1, pelican-server depends on libc and maybe more other c libraries. In deployment, though most Linux systems have libc by default, we may need to check that.

@jhiemstrawisc

Copy link
Copy Markdown
Member

Following up Howard's comment:

$ ldd /usr/local/sbin/pelican-server 
	linux-vdso.so.1 (0x0000ffff9514d000)
	libresolv.so.2 => /lib64/libresolv.so.2 (0x0000ffff950ed000)
	libc.so.6 => /lib64/libc.so.6 (0x0000ffff94f3f000)
	/lib/ld-linux-aarch64.so.1 (0x0000ffff95110000)

@brianhlin

Copy link
Copy Markdown
Contributor

@jhiemstrawisc @h2zh can we just change the origin + director + registry services to use the pelican binary until you guys are ready?

I checked the Dockerfile and that looked fine. Separately, we should probably move the osdf-* containers to the pelican and pelican-server binaries

@h2zh

h2zh commented Jul 16, 2025

Copy link
Copy Markdown
Contributor

I second this plan. Now we should make pelican-server for Cache only

@jhiemstrawisc

Copy link
Copy Markdown
Member

That sounds like a good plan to me. I'm guessing we should hold the 7.18 release for this?

@brianhlin

Copy link
Copy Markdown
Contributor

Noting here that the CGO broke build infrastructure so that change is being rolled back. The change in this PR is now clear to go through with the 7.18 release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

director Issue relating to the director component enhancement New feature or request registry Issue relating to the registry component

Projects

None yet

Development

Successfully merging this pull request may close these issues.

OSDF systemd service files should stop using /usr/bin/osdf name

4 participants