Fix --private-key flag for pelican origin token create#2641
Merged
Conversation
9dd9fbc to
beb2091
Compare
2c8937c to
d700e8a
Compare
jhiemstrawisc
approved these changes
Sep 15, 2025
jhiemstrawisc
left a comment
Member
There was a problem hiding this comment.
I followed the steps in BrianA's reproducer and confirmed this change does generate the token with the correct key. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the PR #2314 that introduced
pelican token createcommand, we changed the function signature ofCreateTokenfromto
However, we forgot to change the token creation code in the legacy
pelican origin token createcommand, which causes the problem in this issue - it uses the private key inIssuerKeysDirectoryto sign the token, instead of the key specified in the command.Close #2163