Fix minor POSIXv2 backend issues#3004
Merged
Merged
Conversation
This commit: - Computes transfer URLs based on the base path provided by the redirector. - Avoids doing a directory listing against a file; there is special XRootD code to handle the error but this approach is more generic for POSIXv2.
- Clients will add a trailing `/` if they think the remote side will be a directory. Remove these at the filesystem layer as it'll cause an unnecessary error if it's actually a file. - When trying to open a directory for write, the filesystem generates an EISDIR which WebDAV translates to a 404. The correct response, however, is 409. This translates the EISDIR appropriately, based on the current WebDAV implementation, to trigger a 409 instead.
POSIXv2 appears much more sensitive to `//` in the URLs
This fixes two small issues: - Ensure storage.modify implies storage.create - Generate ACLs relative to the federation root, not relative to what is provided by the issuer Both fix real failures found in testing.
bbockelm
force-pushed
the
posixv2_fixes
branch
from
57f9d08 to
5e0d965
Compare
Additionally, it will successfully print out client logs on failure.
The code now assumes the transfer attempt URLs have the correct full URL, including path. This was true for the director-provided URLs but NOT for overrides via preferred caches.
Collaborator
Author
|
@turetske - these minor fixes are worth backporting into the next v7.23 RC. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added a small switch that allows you to move all federation tests from POSIX to POSIXv2. This revealed some minor implementation errors / inconsistencies between POSIXv1 (XRootD) and POSIXv2.
With this PR, all tests pass with POSIXv2!
Fixes: #3003