Make pelican_url module threadsafe#3006
Merged
Merged
Conversation
Atomically create and set the global cache; reset it between unit tests. This should fix rare unit test failures where the same port is reused across multiple tests for the discovery URL. As a result, the wrong director URL was being used in tests.
Almost always, disabling TLS verification where it's not needed here indicates a cover-up of a bug. Sure enough, there was one - in the broker client.
bbockelm
added
bug
Collaborator
Author
|
Ok, I've seen a few more of these in the GitHub Actions -- going ahead and pulling it in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3005