Suppress record not found logs#3016
Merged
Merged
Conversation
- GORM would generate a log for each DB query, no matter success (level: debug) or failure (level: error) - However, when the user starts an Origin/Cache for the first time, the DB is empty so the DB query will definitely get a "record not found" error - This error will be logged by GORM by default as an error log. But this may be misleading for the user because this is an expected behavior. The "record not found" is already handled by the subsequent code. - So this commit aims to suppress query logs on these two DB operations to avoid confusions.
h2zh
force-pushed
the
suppress-record-not-found-logs
branch
from
add3115 to
65ea291
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.