Fix a variety of config defaults generation bugs#3081
Merged
Conversation
The warning says nothing in the function should use 'viper.Get*' or 'param.<blah>.Get* and it gives a good reason. Unfortunately, we were still doing exactly that! It turns out it wasn't actually too much of a problem until bugs compounded between PR PelicanPlatform#2869 and PR PelicanPlatform#3042, at which point it broke configuration.
While working on other config bugs, I noticed `pelican config dump` wasn't returning _any_ path for the fed token location. It turns out that's because the default wasn't being set in the default setter. This moves things around to fix the bug.
jhiemstrawisc
added
bug
h2zh
approved these changes
Feb 5, 2026
h2zh
left a comment
h2zh
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Thanks for this emergency surgery to bring the cache back to life!
h2zh
added a commit
to h2zh/pelican
that referenced
this pull request
Feb 5, 2026
- Setup the permanent and temporary directory for the federation token file and sets proper perms. - The permanent directory is always owned by xrootd user. - In normal mode, the temporary directory is owned by the root. While in drop privileges mode, it is owned by the pelican user. - This commit is updated after the changes in PelicanPlatform#3081 to catch up the fixes in the set defaults process
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please refer to issue #3080 for a description of what this fixes, as the proposed fix there was exactly the solution. This also has another small bugfix that should be fairly apparent just by looking at the code or the commits.
Closes #3080