Update to MaterialX v1.38.5#1965
Conversation
|
Filed as internal issue #USD-7523 |
|
@sunyab were there any updates on this PR or #2324 with regards to USD 23.5? MaterialX should be bumping up to 1.38.7 soon, and afaik there aren't any API changes since 1.38.5 (.4 was hopefully an anomaly). 1.38.7 has a lot of niceties including MSL support that would be nice to have in a pipeline. Having this PR in would ease a lot of downstream build complexity. |
|
Hi @dgovil . We never got to the out-of-band work to get 1.38.5 installed in our vfx2020 platform. We are currently filling out our vfx2022 platform, and 1.38.6 is already installed there. We are still hoping to be able to switch to that platform before summer, but there may still be snags that come up. Would it be better to try to get 1.38.5 now, or try to be ready for the release of 1.38.7 and add that to our vfx2022 platform asap? I don't think we have resources to do both. |
|
@spiffmon that's good to know. I agree that VFX Platform 2022 is more important. |
|
Maybe this could be merged without the change to Compatibility is all that is needed for Blender and I imagine various other software, where library versions are not dictated by USD. |
USD 22.08 required MaterialX 1.38.4 minimum. At Autodesk we want to align on 1.38.5. The changes are based on an open Pixar PR PixarAnimationStudios#1965 (cherry picked from commit d9b3c81) Co-authored-by: Pablo Delgado Krämer <private@pablode.com>
Description of Change(s)
This PR makes USD (specifically hdStorm) MaterialX 1.38.5-ready.
The changes between 1.38.4 and 1.38.5 are addressed as following:
the new transmission handling option is set to
TRANSMISSION_OPACITYfor tests to pass as suggested by @JGamache-autodesk (#929)addition of the emission call for said option (#994)
changes for code generation from material nodes (#981)
lastly, Jonathan inlined the
GlslShaderGenerator::TARGETconstant in #926, which doesn't need an #ifguard because the value is the same in both 1.38.3 and 1.38.4I have submitted a signed Contributor License Agreement