Use non-deprecated TBB headers in pxr/base/work#2321
Merged
pixar-oss merged 1 commit intoPixarAnimationStudios:devfrom Aug 4, 2023
Merged
Use non-deprecated TBB headers in pxr/base/work#2321pixar-oss merged 1 commit intoPixarAnimationStudios:devfrom
pxr/base/work#2321pixar-oss merged 1 commit intoPixarAnimationStudios:devfrom
Conversation
Contributor
|
Filed as internal issue #USD-8082 |
musicinmybrain
pushed a commit
to musicinmybrain/OpenUSD
that referenced
this pull request
Apr 7, 2026
…ixarAnimationStudios#2321) Pointer arithmetic involving `srcbuffer` in the `unpack_*` functions can overflow for very wide images. Multiplying `int w` by a bytes-per-element constant (2, 4, 6, or 8) in `srcbuffer +=` expressions causes signed integer overflow when the image width is large. Promote the leading operand to `int64_t` at every affected multiplication so pointer arithmetic is performed in 64-bit signed arithmetic throughout, eliminating the undefined behavior without imposing any image size limit. Affected sites: `generic_unpack`, `unpack_16bit`, `unpack_32bit`, and all 3- and 4-channel interleave/planar specializations. Made-with: Cursor Signed-off-by: Cary Phillips <cary@ilm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
tbb/task.his deprecated / removed in newer versions of TBB, buttbb/task_group.his not. Usingtbb/task_group.hwhen possible reduces the warning count when building with TBB 2020.3 and is a small step in makingpxr/base/workcompatible with oneAPI.Fixes Issue(s)
This PR is related to the issues above, but does not fully address.