APPLE: Use System API for Temporary Directory location#3705
Closed
dgovil wants to merge 5 commits intoPixarAnimationStudios:devfrom
Closed
APPLE: Use System API for Temporary Directory location#3705dgovil wants to merge 5 commits intoPixarAnimationStudios:devfrom
dgovil wants to merge 5 commits intoPixarAnimationStudios:devfrom
Conversation
10 tasks
dgovil
added
the
needs review
Collaborator
|
Filed as internal issue #USD-11182 (This is an automated message. See here for more information.) |
dgovil
force-pushed
the
UseSystemTempDirAPIs
branch
from
2a38307 to
c4af338
Compare
dgovil
force-pushed
the
UseSystemTempDirAPIs
branch
from
c4af338 to
a207a4f
Compare
Collaborator
|
Hi Dhruv! It looks like there are some build tests that aren't passing on macOS; https://github.com/PixarAnimationStudios/OpenUSD/actions/runs/17986295830/job/52177008489. Would it be possible to have someone take a look? 🙏🏻 |
Collaborator
Author
|
Ah weird. I'll take a look today. |
Collaborator
Author
|
I'm having a hard time reproducing the issues locally, but I have @danknowlton_apple looking into it |
Collaborator
Author
|
@jesschimein I think I fixed this. Difference in memory allocations between debug/release. |
Member
|
Thank you!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
This change now uses the system API to get the temporary directory, instead of looking up the environment variable.
This matches the Windows behaviour, and is required for use with the stricter containerized temp directory in macOS 26 when used from sandbox processes.
Changes made:
darwin.handdarwin.mmfiles in thearchtarget for using darwin specific code via ObjectiveC++ARCH_PLATFORM_HEADERSandARCH_PLATFORM_CPPFILESto the arch cmakelists. RenamePLATFORM_LIBStoARCH_PLATFORM_LIBSto align the style with the garch target.Arch_InitTmpDirto callArch_DarwinGetTemporaryDirectoryon Darwin platforms.Checklist
I have created this PR based on the dev branch
I have followed the coding conventions
I have added unit tests that exercise this functionality (Reference:
testing guidelines)
I have verified that all unit tests pass with the proposed changes
I have submitted a signed Contributor License Agreement (Reference:
Contributor License Agreement instructions)