APPLE: Extract TBB Patches#3706
Closed
dgovil wants to merge 1 commit intoPixarAnimationStudios:devfrom
Closed
Conversation
dgovil
added
needs review
10 tasks
dgovil
added a commit
to dgovil/USD
that referenced
this pull request
Jul 5, 2025
Requires PixarAnimationStudios#3706 to be merged first
5 tasks
Collaborator
|
Filed as internal issue #USD-11183 (This is an automated message. See here for more information.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
As discussed with @meshula , this PR moves the TBB patches from the main build_usd.py to apple_utils.py so that we can introduce more platform specific patches in the future. This PR will be necessary for adding future PRs for Simulator support or any other apple platforms that might get added here (e.g tvOS or watchOS purely hypothetically)
TBB will still be required once GCD lands in OpenUSD for some of the algorithms, so this patch is still necessary.
There is no functional behaviour change here.
Additionally, as part of this change, GetSDKRoot has been split into GetSDKName and GetSDKRoot, and now verifies that the SDK is installed in the currently active Xcode.
Checklist
I have created this PR based on the dev branch
I have followed the coding conventions
I have added unit tests that exercise this functionality (Reference:
testing guidelines)
I have verified that all unit tests pass with the proposed changes
I have submitted a signed Contributor License Agreement (Reference:
Contributor License Agreement instructions)