APPLE: Enable Building as Framework#3713
Open
dgovil wants to merge 4 commits intoPixarAnimationStudios:devfrom
Open
APPLE: Enable Building as Framework#3713dgovil wants to merge 4 commits intoPixarAnimationStudios:devfrom
dgovil wants to merge 4 commits intoPixarAnimationStudios:devfrom
Conversation
10 tasks
This was referenced Jul 8, 2025
Collaborator
|
Filed as internal issue #USD-11201 (This is an automated message. See here for more information.) |
tlewis
reviewed
Apr 9, 2026
|
|
||
| # Set that Apple Framework is being build | ||
| if (PXR_BUILD_APPLE_FRAMEWORK) | ||
| _add_define("PXR_BUILD_APPLE_FRAMEWORK") |
Contributor
There was a problem hiding this comment.
Hi @dgovil - I'm curious what the motivation is for this. It's currently not used by anything so is this ok to remove?
Collaborator
Author
There was a problem hiding this comment.
Yeah I think it can be removed. It was vestigial from when I spilt up the PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
This PR separates out just the framework build part of #2969 into an isolated PR, and addresses the notes from @meshula in the process.
Overview of Changes
build_usd.pynow adds a--build-apple-frameworkand--no-build-apple-frameworkto enable building frameworks. Frameworks are enabled by default for embedded OS builds.PXR_EXTRA_BINARY_RELATIVE_RESOURCESallows the resource directory to be configured relative to the binary. This avoids hardcoding patterns in the CPP files, and allows configuration in CMake. This was requested by @meshula as well.Checklist
I have created this PR based on the dev branch
I have followed the coding conventions
I have added unit tests that exercise this functionality (Reference:
testing guidelines)
I have verified that all unit tests pass with the proposed changes
I have submitted a signed Contributor License Agreement (Reference:
Contributor License Agreement instructions)