[arch] Added fallback for Windows plugin loading when MAX_PATH is exceeded#4047
Open
DuncanHopkinsFoundry wants to merge 1 commit intoPixarAnimationStudios:devfrom
Open
Conversation
…eeded. Added second LoadLibrary call on windows, if the first one fails. The seconds call will add the Windows UNC header to an abs file path: "\\?\". If the first failure was related to the path being too long, then this fixes the issue. Without changing the original behaviour. Fixes PixarAnimationStudios#4046
Collaborator
|
Filed as internal issue #USD-12104 ❗ Please make sure that a signed CLA has been submitted! (This is an automated message. See here for more information.) |
Member
|
I suspect the answer is no, but @DuncanHopkinsFoundry , would this fix be subsumed or obviated by PR #2239 , which we have queued to pull in this year? |
Author
It definitely looks like the same sort of thing. At a very quick browse I am not seeing the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
Added second LoadLibrary call on windows, if the first one fails. The seconds call will add the Windows UNC header to an abs file path: "\?". If the first failure was related to the path being too long, then this fixes the issue. Without changing the original behaviour.
Fixes Issue(s)
Fixes #4046
Checklist
I have created this PR based on the dev branch
I have followed the coding conventions
I have added unit tests that exercise this functionality (Reference:
testing guidelines)
I have verified that all unit tests pass with the proposed changes
I have submitted a signed Contributor License Agreement (Reference:
Contributor License Agreement instructions)