Refactor getInliers(), getModel(), getModelCoefficients() to return a const reference#6251
Closed
jose-n9 wants to merge 1 commit intoPointCloudLibrary:masterfrom
Closed
Refactor getInliers(), getModel(), getModelCoefficients() to return a const reference#6251jose-n9 wants to merge 1 commit intoPointCloudLibrary:masterfrom
jose-n9 wants to merge 1 commit intoPointCloudLibrary:masterfrom
Conversation
… return a const reference instead of modifiying parameters
mvieth
added
changelog: enhancement
Member
|
@jose-n9 Thanks for the pull request. However, please do not replace the old functions, just add the new functions. The old/existing functions are used in several places within PCL and likely also by other projects using PCL, so we cannot simply remove them. |
Member
|
Closing due to no reply, and checks are failing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the original code, we pass an object as a parameter and modify it. In the new code, we return a const reference to an internal object. This change eliminates unnecessary data copying, provides more flexibility, and, most importantly, improves efficiency.
Original:
inline void getInliers (Indices &inliers) const { inliers = inliers_; }Updated to return a const reference:
inline const Indices& getInliers() const { return inliers_; }