Unit test for MovingLeastSquares NaN output in certain conditions#788
Unit test for MovingLeastSquares NaN output in certain conditions#788translunar wants to merge 5 commits intoPointCloudLibrary:masterfrom
Conversation
output (and probably should not).
translunar
changed the title
There was a problem hiding this comment.
We have a special function to test if a point is finite: pcl::isFinite(pt).
|
@taketwo Thanks for the feedback. I have corrected the test. |
There was a problem hiding this comment.
This should be PCL_ERROR as well.
|
Hi @MohawkJohn, I've added some comments (there are some more style errors, I guess you will find them ;) ). Once you fix them, could you squash your commits? Then I'm fine with merging this. |
|
I think we don't want to merge this. It exposes a bug, but does not fix it. If we merge it, we will get a test case which always fails. |
|
@taketwo Yeah, the goal here was to expose a bug, not to get this merged. I don't know how to address this particular problem, but thought I should spec it. |
|
The implementation of #1407 (comment) should fix this. I'll make sure this test is included then. |
4 participants
This includes a test case which demonstrates #787. It's not a race condition after all, but a problem caused by the covariance computation method used for MovingLeastSquares.
I haven't removed the additional debugging message since this problem hasn't actually been fixed. In other words, this pull request probably isn't ready for a merge, but I wanted to make the unit test available.