Fix helm-docs step failing when there are no changes#24
Merged
mitchnielsen merged 1 commit intomainfrom Oct 21, 2025
Merged
Conversation
The helm-docs step was failing with exit code 1 when there were no documentation changes to commit. This occurred because the shell's `set -e` flag (from the default bash configuration) causes immediate exit on any non-zero exit code, and `git commit` returns 1 when there's nothing to commit. This fix adds a check for actual file changes before attempting to commit and push. If helm-docs doesn't generate any changes, the step now completes successfully without trying to commit. Related: https://github.com/PrefectHQ/prefect-operator/actions/runs/18656329028/job/53186252489 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
jamiezieziula
approved these changes
Oct 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The helm-docs step was failing with exit code 1 when there were no documentation changes to commit. This occurred because the shell's
set -eflag (from the default bash configuration) causes immediate exit on any non-zero exit code, andgit commitreturns 1 when there's nothing to commit.This fix adds a check for actual file changes before attempting to commit and push. If helm-docs doesn't generate any changes, the step now completes successfully without trying to commit.
Related: https://github.com/PrefectHQ/prefect-operator/actions/runs/18656329028/job/53186252489