Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d9c6884c2a
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| Token audience is bound to this server automatically: when the MCP | ||
| mount path becomes known (typically at ``http_app()`` construction), | ||
| ``JWTVerifier.audience`` is set to the resource URL advertised in | ||
| ``.well-known/oauth-protected-resource``. Enable Resource Indicators | ||
| (RFC 8707) in your WorkOS Dashboard and list that same URL — AuthKit |
There was a problem hiding this comment.
Qualify audience auto-binding as default-verifier only
This new paragraph says token audience is bound automatically once the MCP mount path is known, but in AuthKitProvider.set_mcp_path that only happens when _auto_bind_audience is true (i.e., when no custom token_verifier was provided in __init__; see src/fastmcp/server/auth/providers/workos.py). With a custom verifier, the audience is not auto-set, so this wording can mislead users into skipping required verifier configuration and then seeing valid WorkOS tokens rejected.
Useful? React with 👍 / 👎.
d9c6884 to
010a4f1
Compare
010a4f1 to
ced6a3a
Compare
Co-authored-by: marvin-context-protocol[bot] <225465937+marvin-context-protocol[bot]@users.noreply.github.com>
This PR updates the auto-generated SDK documentation to reflect the latest source code changes.
📚 Documentation is automatically generated from the source code docstrings and type annotations.
Note: This PR is fully automated and will update itself with any subsequent changes to the SDK, or close automatically if the documentation becomes up-to-date through other means. Feel free to leave it open until you're ready to merge.
🤖 Generated by Marvin