Update Slackbot documentation to reflect current implementation#1204
Merged
Update Slackbot documentation to reflect current implementation#1204
Conversation
- Document GPT-5 model support and configuration - Add comprehensive list of Prefect Variables and Secrets - Include new settings like MAX_TOOL_CALLS_PER_TURN - Clarify temperature auto-adjustment for GPT-5 - Remove duplicate USER_MESSAGE_MAX_TOKENS definition - Update CLAUDE.md with current configuration details 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Slackbot documentation to accurately reflect the current implementation after switching to GPT-5 support and adding new configuration options. The documentation had become outdated and this brings it in line with the actual codebase capabilities.
- Updated documentation to include GPT-5 model support alongside Claude
- Added comprehensive configuration details including new Prefect Variables and Secrets
- Removed duplicate code definition that was already imported from settings
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| examples/slackbot/src/slackbot/core.py | Removed duplicate USER_MESSAGE_MAX_TOKENS definition that's properly imported from settings |
| examples/slackbot/README.md | Updated to document GPT-5 support, comprehensive configuration variables, and model selection options |
| examples/slackbot/CLAUDE.md | Updated architecture documentation with current model support and detailed configuration requirements |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
- Replace Variable.aget() with hardcoded Marvin-style welcome message - Remove unused Variable import from api.py - Update documentation to remove marvin_welcome_message variable - Welcome message now provides docs, GitHub, and community info with Marvin's characteristic tone 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- move prompts to dedicated prompts.py module for cleaner separation - refactor wrap.py with proper separation of concerns: - generic monkey-patching in _internal/monkey_patch.py - tool tracking/limiting in _internal/tool_tracking.py - prefect integration stays in wrap.py - fix double tool execution in prefect ui by using context variables to prevent duplicate wrapping when subclasses call super() or delegate - move welcome message from prefect variable to version-controlled code 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
summary
changes
documentation updates
MAX_TOOL_CALLS_PER_TURNcode refactoring
_internal/monkey_patch.py_internal/tool_tracking.pywrap.pybug fixes
USER_MESSAGE_MAX_TOKENSdefinitioncontext
the slackbot had accumulated technical debt with configuration spread across variables and messy wrapper logic. this pr modernizes the codebase while fixing a critical bug where tools were being executed twice in the prefect ui, improving both maintainability and performance.
🤖 Generated with Claude Code