Fix IndexError in streaming when ToolCallPartDelta is present#1208
Merged
Fix IndexError in streaming when ToolCallPartDelta is present#1208
Conversation
When pydantic-ai streams incomplete tool calls (ToolCallPartDelta), the event.index refers to the position in the internal _parts list, but get_parts() filters out these incomplete parts. This causes an IndexError when trying to access get_parts()[index]. The fix uses the internal _parts list directly for snapshots, since that's what the event indices refer to. Fixes #1207 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
Fixes an IndexError that occurs when processing streaming tool calls in pydantic-ai events. The issue arises when ToolCallPartDelta objects are present but filtered out by get_parts(), causing a mismatch between event indices and accessible parts.
- Modified
_get_snapshot()to use the internal_partslist directly instead of the filteredget_parts()method - Added bounds checking to prevent accessing invalid indices
- Added comprehensive unit test to verify the fix and prevent regression
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/marvin/engine/streaming.py | Updated _get_snapshot() to access _parts directly with bounds checking |
| tests/basic/engine/test_streaming.py | Added test case reproducing the IndexError scenario with incomplete tool calls |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1207 - IndexError when processing pydantic events in streaming
Problem
When pydantic-ai streams incomplete tool calls (ToolCallPartDelta), the event.index refers to the position in the internal
_partslist, butget_parts()filters out these incomplete parts. This causes an IndexError when trying to accessget_parts()[index].Solution
_partslist directly for snapshots, since that's what the event indices refer totool_call_idattribute_get_snapshotcan return None (though this should never happen with valid events)Test Plan
🤖 Generated with Claude Code