Export names from the top level of xmlmap (#17)#18
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18 +/- ##
==========================================
- Coverage 85.50% 85.21% -0.29%
==========================================
Files 15 15
Lines 2215 2165 -50
==========================================
- Hits 1894 1845 -49
+ Misses 321 320 -1 🚀 New features to boost your workflow:
|
rlskoeser
left a comment
rlskoeser
left a comment
There was a problem hiding this comment.
Thank you for fixing this! Sorry for the extra work, but glad for the solution we arrived at.
| load_xmlobject_from_file as load_xmlobject_from_file, | ||
| load_xslt as load_xslt, | ||
| ) | ||
| from neuxml.xmlmap.fields import ( |
There was a problem hiding this comment.
ruff requires this syntax? import thing as thing?
There was a problem hiding this comment.
Yes, otherwise it complains about it being an unused import (F401). It offers this solution as help text during pre-commit:
help: Use an explicit re-export: `XmlObject as XmlObject`
There was a problem hiding this comment.
Could we use the __all__ syntax instead? Sorry for the change, but that feels more readable / slightly less redundant to me.
https://docs.astral.sh/ruff/rules/unused-import/#why-is-this-bad
2 participants
Associated Issue(s): #17
Changes in this PR
xmlmapmodule instead of requiring references to submodules, in a way that Ruff acceptsxmlmap.XYZstyleMIGRATION.rst